Skip to content

Move /analytics contract page in app router folder (no code change) #5046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2024
Merged

Move /analytics contract page in app router folder (no code change) #5046

merged 1 commit into from
Oct 15, 2024
+1 −1

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 15, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on updating the import path for the ContractAnalyticsPage component in the page.tsx file located in the analytics directory. The change simplifies the import statement by using a relative path.

Detailed summary

  • Changed the import path of ContractAnalyticsPage from a long relative path to a shorter one ("./ContractAnalyticsPage").
  • The file structure indicates a shift from a deeply nested import to a more accessible one within the same directory.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 10:42pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 15, 2024 10:42pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 15, 2024 10:42pm
wallet-ui ⬜️ Skipped (Inspect) Oct 15, 2024 10:42pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 October 15, 2024 22:06 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 15, 2024 22:06 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 15, 2024 22:06 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2ed3be2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 15, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@MananTank MananTank mentioned this pull request Oct 15, 2024
Merged
@MananTank Graphite App
Copy link
Member Author

MananTank commented Oct 15, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@MananTank MananTank marked this pull request as ready for review October 15, 2024 22:06
This was referenced Oct 15, 2024
Merged
Merged
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 15, 2024
@codecov
Copy link

codecov bot commented Oct 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.30%. Comparing base (0159983) to head (2ed3be2).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5046   +/-   ##
=======================================
  Coverage   45.30%   45.30%           
=======================================
  Files        1059     1059           
  Lines       54714    54714           
  Branches     3953     3953           
=======================================
  Hits        24787    24787           
  Misses      29236    29236           
  Partials      691      691
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 0159983
packages 40.24% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.77 KB (0%) 856 ms (0%) 3.5 s (+8.34% 🔺) 4.3 s
thirdweb (cjs) 102.62 KB (0%) 2.1 s (0%) 5.5 s (-5.67% 🔽) 7.6 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 249 ms (+68.63% 🔺) 346 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 100 ms (+74.35% 🔺) 110 ms
thirdweb/react (minimal + tree-shaking) 17.35 KB (0%) 347 ms (0%) 457 ms (-39.24% 🔽) 804 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 15, 2024 •
edited by jnsdls
Loading

Merge activity

@MananTank
Move /analytics contract page in app router folder (no code change) (#…
2ed3be2 
…5046)

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the import path for the `ContractAnalyticsPage` component in the `page.tsx` file located in the analytics tab of the dashboard. It simplifies the import by using a relative path.

### Detailed summary
- Changed the import path for `ContractAnalyticsPage` from a long relative path to a simplified relative import (`"./ContractAnalyticsPage"`).
- No other significant changes are noted in the diff.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the 10-16-move__accounts_contract_page_in_app_router_folder_no_code_change_ branch from 257f10b to 0159983 Compare October 15, 2024 22:27
@jnsdls jnsdls force-pushed the 10-16-move__analytics_contract_page_in_app_router_folder_no_code_change_ branch from 37820aa to 2ed3be2 Compare October 15, 2024 22:28
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 15, 2024 22:28 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 15, 2024 22:28 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 15, 2024 22:28 Inactive
@MananTank MananTank mentioned this pull request Oct 15, 2024
Merged
Base automatically changed from 10-16-move__accounts_contract_page_in_app_router_folder_no_code_change_ to main October 15, 2024 22:42
@graphite-app graphite-app bot merged commit 2ed3be2 into main Oct 15, 2024
29 checks passed
@graphite-app graphite-app bot deleted the 10-16-move__analytics_contract_page_in_app_router_folder_no_code_change_ branch October 15, 2024 22:43
@vercel vercel bot temporarily deployed to Production – docs-v2 October 15, 2024 22:43 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui October 15, 2024 22:43 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 15, 2024 22:43 Inactive
@MananTank MananTank mentioned this pull request Oct 15, 2024
Merged
@vercel vercel bot temporarily deployed to Production – thirdweb-www October 15, 2024 22:58 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls jnsdls approved these changes

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MananTank @jnsdls